Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary macro_uses in rustdoc #90412

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Remove unnecessary macro_uses in rustdoc #90412

merged 1 commit into from
Oct 30, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Oct 30, 2021

No description provided.

@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 30, 2021
@rust-highfive
Copy link
Collaborator

r? @ollie27

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 30, 2021
@jyn514
Copy link
Member Author

jyn514 commented Oct 30, 2021

r? @camelid

@rust-highfive rust-highfive assigned camelid and unassigned ollie27 Oct 30, 2021
camelid
camelid approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! r=me with CI passing and, optionally, the nit below addressed

src/librustdoc/html/render/context.rs Outdated Show resolved Hide resolved
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514
Copy link
Member Author

jyn514 commented Oct 30, 2021

@bors r=camelid rollup

@bors
Copy link
Contributor

bors commented Oct 30, 2021

📌 Commit b6851ba has been approved by camelid

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 30, 2021
@matthiaskrgr
Rollup merge of rust-lang#90412 - jyn514:macro-use, r=camelid
702f251 
Remove unnecessary `macro_use`s in rustdoc
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 30, 2021
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 30, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 30, 2021
@bors
Auto merge of rust-lang#90416 - matthiaskrgr:rollup-55lzqng, r=matthi…
9f13083 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#89876 (Make most std::ops traits const on numeric types)
 - rust-lang#90371 (Fix incorrect doc link)
 - rust-lang#90374 (Unify titles in rustdoc book doc attributes chapter)
 - rust-lang#90377 (Make `core::slice::from_raw_parts[_mut]` const)
 - rust-lang#90395 (Restrict liveness of mutable borrow of inner infcx in ConstInferUnifier::consts)
 - rust-lang#90396 (Prevent type flags assertions being thrown in default_anon_const_substs if errors occurred)
 - rust-lang#90402 (Add a few query descriptions)
 - rust-lang#90412 (Remove unnecessary `macro_use`s in rustdoc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 19b5b0f into rust-lang:master Oct 30, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 30, 2021
@jyn514 jyn514 deleted the macro-use branch February 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid approved these changes

Assignees

@camelid camelid

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jyn514 @rust-highfive @rust-log-analyzer @bors @camelid @ollie27 @rustbot